Remove unused variables from 6300ESB smbus_write_block().
#if 0 smbus_write_byte() and smbus_write_block() as they are static and nothing uses them or are incompletely implemented.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net ---
Jonathan A. Kollasch wrote:
Remove unused variables from 6300ESB smbus_write_block().
#if 0 smbus_write_byte() and smbus_write_block() as they are static and nothing uses them or are incompletely implemented.
Why #if 0 rather than just removing the code completely? I think this is a piece of code which can already be found other places if a reference is needed?
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net
Acked-by: Peter Stuge peter@stuge.se
On 18.10.2010, at 12:17, Peter Stuge peter@stuge.se wrote:
Jonathan A. Kollasch wrote:
Remove unused variables from 6300ESB smbus_write_block().
#if 0 smbus_write_byte() and smbus_write_block() as they are static and nothing uses them or are incompletely implemented.
Why #if 0 rather than just removing the code completely? I think this is a piece of code which can already be found other places if a reference is needed?
Maybe use #ifdef DEADCODE if you want to leave it in. That will make it easier to recognize that the code was considered for dropping once before.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net
Acked-by: Peter Stuge peter@stuge.se
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Mon, Oct 18, 2010 at 03:25:31PM +0000, Jonathan A. Kollasch wrote:
Remove unused variables from 6300ESB smbus_write_block().
#if 0 smbus_write_byte() and smbus_write_block() as they are static and nothing uses them or are incompletely implemented.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net
r5972
-
Jonathan A. Kollasch -
Peter Stuge -
Stefan Reinauer