[PATCH] Add easy SeaBIOS as payload option

[Stefan Reinauer]

See patch

[Idwer Vollering]

2010/12/26 Stefan Reinauer
> See patch

Nice. Can you extend it so the serial port number, "#define DEBUG_PORT
PORT_SERIAL1", in $seabios_dir/src/output.c is shared with
CONFIG_CONSOLE_SERIAL_COM1 in coreboot's .config, and so on for COM2..4 ?
Dito for "#define CONFIG_DEBUG_LEVEL 1" in $seabios_dir/src/config.h and
"CONFIG_DEFAULT_CONSOLE_LOGLEVEL=8" and/or CONFIG_MAXIMUM_CONSOLE_LOGLEVEL
in .config.

Using releases ( http://seabios.org/Releases ) instead of code from seabios'
git repo sounds like a better idea to me.

Idwer
>

[Patrick Georgi]

Am 27.12.2010 01:06, schrieb Idwer Vollering:
> Nice. Can you extend it so the serial port number, "#define DEBUG_PORT
> PORT_SERIAL1", in $seabios_dir/src/output.c is shared with
> CONFIG_CONSOLE_SERIAL_COM1 in coreboot's .config, and so on for COM2..4 ?
> Dito for "#define CONFIG_DEBUG_LEVEL 1" in $seabios_dir/src/config.h and
> "CONFIG_DEFAULT_CONSOLE_LOGLEVEL=8" and/or
> CONFIG_MAXIMUM_CONSOLE_LOGLEVEL in .config.

Been thinking of extending that scheme so that we mirror seabios'
config.h in Kconfig and generate config.h from coreboot's configuration.
Something like CONFIG_SEABIOS_* (in coreboot's config) to CONFIG_* (for
seabios), and some of the values can default to match coreboot's values.

Patrick

[Kevin O'Connor]

On Mon, Dec 27, 2010 at 08:31:21AM +0100, Patrick Georgi wrote:
> Am 27.12.2010 01:06, schrieb Idwer Vollering:
> > Nice. Can you extend it so the serial port number, "#define DEBUG_PORT
> > PORT_SERIAL1", in $seabios_dir/src/output.c is shared with
> > CONFIG_CONSOLE_SERIAL_COM1 in coreboot's .config, and so on for COM2..4 ?
> > Dito for "#define CONFIG_DEBUG_LEVEL 1" in $seabios_dir/src/config.h and
> > "CONFIG_DEFAULT_CONSOLE_LOGLEVEL=8" and/or
> > CONFIG_MAXIMUM_CONSOLE_LOGLEVEL in .config.
>
> Been thinking of extending that scheme so that we mirror seabios'
> config.h in Kconfig and generate config.h from coreboot's configuration.
> Something like CONFIG_SEABIOS_* (in coreboot's config) to CONFIG_* (for
> seabios), and some of the values can default to match coreboot's values.

It would be nice to add Kconfig support to SeaBIOS.  It shouldn't be
too hard, but I haven't had time to see what it would take.

-Kevin

[Stefan Reinauer]

* Idwer Vollering  [101227 01:06]:
> Nice. Can you extend it so the serial port number, "#define DEBUG_PORT
> PORT_SERIAL1", in $seabios_dir/src/output.c is shared with
> CONFIG_CONSOLE_SERIAL_COM1 in coreboot's .config, and so on for COM2..4 ?

I think to keep patching files in SeaBIOS to a minimum that define
should be moved to SeaBIOS' config.h first.
> Dito for "#define CONFIG_DEBUG_LEVEL 1" in $seabios_dir/src/config.h and
> "CONFIG_DEFAULT_CONSOLE_LOGLEVEL=8" and/or CONFIG_MAXIMUM_CONSOLE_LOGLEVEL in
> .config.

Do those log levels map 1:1 between coreboot and seabios?
> Using releases ( http://seabios.org/Releases ) instead of code from seabios'
> git repo sounds like a better idea to me.

Done.

Stefan

[Kevin O'Connor]

On Sun, Dec 26, 2010 at 10:11:24PM +0100, Stefan Reinauer wrote:
[...]
> +patch: checkout
> test -r seabios/.patched || \
> perl -pi -e "s,#define CONFIG_COREBOOT 0,#define CONFIG_COREBOOT 1,;" \
>  -e "s,#define CONFIG_DEBUG_SERIAL 0,#define CONFIG_DEBUG_SERIAL 1,;" \
>  -e "s,#define CONFIG_VGAHOOKS 0,#define CONFIG_VGAHOOKS 1,;" \
>  -e "s,#define CONFIG_AHCI 0,#define CONFIG_AHCI 1," \
>  seabios/src/config.h

CONFIG_AHCI is a bit experimental.  Has there been success with it on
real hardware?
> +checkout:
> test -d seabios && ( cd seabios; git pull ) || \
> git clone git://git.linuxtogo.org/home/kevin/seabios.git seabios

I'd hate to have an accidental commit brick someones machine.  This
should probably pull out a tagged version.  Another option would be to
commit a compressed bios.bin.elf file to svn (the gzip'd elf file is
only 56K).

-Kevin

[Stefan Reinauer]

* Kevin O'Connor  [101228 01:00]:
> CONFIG_AHCI is a bit experimental.  Has there been success with it on
> real hardware?

I have not tried it. It sounded like a great idea though.
> > +checkout:
> > test -d seabios && ( cd seabios; git pull ) || \
> > git clone git://git.linuxtogo.org/home/kevin/seabios.git seabios
>
> I'd hate to have an accidental commit brick someones machine.  This
> should probably pull out a tagged version.  Another option would be to
> commit a compressed bios.bin.elf file to svn (the gzip'd elf file is
> only 56K).

I agree. A tagged version seems a better default. Comitting binaries
sounds not so nice, if there's a chance to build from sources.

Stefan