Re: [LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Lu, Yinghai]

Please try another switch

In southbridge/amd/amd8111/amd8111_pci.c

Line dword |= (1<<27) /* discard Timer */
===> dword &= ~(1<<27);

YH

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Ward Vandewege
Sent: Monday, April 10, 2006 7:15 AM
To: Alan Mimms
Cc: [e-mail]; Lu, Yinghai
Subject: Re: [LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

On Fri, Apr 07, 2006 at 04:00:28PM -0700, Alan Mimms wrote:
> The code should be setting the 1<<4 bit (so as to clear one of the

error
> bits) instead of 1<<6 (the read only bit that signals end of HT bus
> chain).
>
> After making this change, your board won't hang when the BIOS or Linux
> detects a need to reboot due to some fatal error.
>
> This is a pretty trivial change to an error case that hardly ever

occurs
> but was crucial for us.  I claim this change is safe and correct and
> should be merged into the main line code.

Yes, please merge that change!

Our box now keeps rebooting itself instead of crashing - have a look at
the
attached boot log. Maybe this will be more of a clue as to what exactly
is
happening? Anyone got anymore ideas?

Thanks, Alan!!
Ward.

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Ward Vandewege]

On Mon, Apr 10, 2006 at 09:01:03AM -0700, Lu, Yinghai wrote:
> Please try another switch
>
> In southbridge/amd/amd8111/amd8111_pci.c
>
> Line dword |= (1<<27) /* discard Timer */
> ===> dword &= ~(1<<27);

Yinghai, you're a hero! The box has been up for 1 hour and 45 minutes. I
think the problem is solved. I'll do more stress testing, but it really looks
like this patch should go into the mainline linuxbios tree.

Thanks!
Ward.

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Stefan Reinauer]

* Ward Vandewege  [060410 20:23]:
> On Mon, Apr 10, 2006 at 09:01:03AM -0700, Lu, Yinghai wrote:
> > Please try another switch
> >
> > In southbridge/amd/amd8111/amd8111_pci.c
> >
> > Line dword |= (1<<27) /* discard Timer */
> > ===> dword &= ~(1<<27);
>
> Yinghai, you're a hero! The box has been up for 1 hour and 45 minutes. I
> think the problem is solved. I'll do more stress testing, but it really looks
> like this patch should go into the mainline linuxbios tree.

Is this with both changes from this thread applied?

Stefan

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[yhlu]

Not yet.

On 4/11/06, Stefan Reinauer  wrote:
> Ward Vandewege  [060410 20:23]:
> > On Mon, Apr 10, 2006 at 09:01:03AM -0700, Lu, Yinghai wrote:
> > > Please try another switch
> > >
> > > In southbridge/amd/amd8111/amd8111_pci.c
> > >
> > > Line dword |= (1<<27) /* discard Timer */
> > > ===> dword &= ~(1<<27);
> >
> > Yinghai, you're a hero! The box has been up for 1 hour and 45 minutes. I
> > think the problem is solved. I'll do more stress testing, but it really looks
> > like this patch should go into the mainline linuxbios tree.
>
> Is this with both changes from this thread applied?
>
> Stefan

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Ward Vandewege]

On Tue, Apr 11, 2006 at 10:28:06AM +0200, Stefan Reinauer wrote:
> Ward Vandewege  [060410 20:23]:
> > On Mon, Apr 10, 2006 at 09:01:03AM -0700, Lu, Yinghai wrote:
> > > Please try another switch
> > >
> > > In southbridge/amd/amd8111/amd8111_pci.c
> > >
> > > Line dword |= (1<<27) /* discard Timer */
> > > ===> dword &= ~(1<<27);
> >
> > Yinghai, you're a hero! The box has been up for 1 hour and 45 minutes. I
> > think the problem is solved. I'll do more stress testing, but it really looks
> > like this patch should go into the mainline linuxbios tree.
>
> Is this with both changes from this thread applied?

All three in fact - to my local tree. But the first one (small fix from YH on
Friday) has already been applied in the svn tree I see.

Ward.

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Stefan Reinauer]

* Ward Vandewege  [060411 13:37]:
> All three in fact - to my local tree. But the first one (small fix from YH on
> Friday) has already been applied in the svn tree I see.
>
> Ward.

Ok, committed in revision 2251. Could you please update to this version
and verify it's working correctly?

Stefan

[LinuxBIOS] CONFIG_LB_MEM_TOPK (and a patch)

[Ward Vandewege]

On Tue, Apr 11, 2006 at 08:38:06PM +0200, Stefan Reinauer wrote:
> Ward Vandewege  [060411 13:37]:
> > All three in fact - to my local tree. But the first one (small fix from YH on
> > Friday) has already been applied in the svn tree I see.
> >
> > Ward.
>
> Ok, committed in revision 2251. Could you please update to this version
> and verify it's working correctly?

I've checked out a clean 2254 tree. Compiled & installed, works great still.

Thanks,
Ward.