Re: [coreboot] [LinuxBIOS] PATCH: lx car that returns from disable_car

[ron minnich]

On Jan 11, 2008 4:01 PM, Marc Jones  wrote:
> Ron,
>
> I think I am up to the same point you are. It looks like there is a
> problem in the device scanning.
>
> void dev_phase2(void) should call geodelx_pci_domain_phase2() for the
> southbridge device.
>
> Here is the output. Is this the correct order? It seems strange.
>
> Phase 2: Early setup...
> dev_phase2: dev root:
> dev_phase2: dev cpus:
> dev_phase2: dev device0_0:
> dev_phase2: dev southbridge:
> dev_phase2: dev domain0:
> Phase 2: Done.

I just realized there was no dts in northbridge/amd/geodelx ... this
is a possible problem.

patch attached.

ron

[LinuxBIOS] PATCH: lx car that returns from disable_car

[Carl-Daniel Hailfinger]

On 17.01.2008 02:18, ron minnich wrote:
> On Jan 11, 2008 4:01 PM, Marc Jones  wrote:
> > Ron,
> >
> > I think I am up to the same point you are. It looks like there is a
> > problem in the device scanning.
> >
> > void dev_phase2(void) should call geodelx_pci_domain_phase2() for the
> > southbridge device.
> >
> > Here is the output. Is this the correct order? It seems strange.
> >
> > Phase 2: Early setup...
> > dev_phase2: dev root:
> > dev_phase2: dev cpus:
> > dev_phase2: dev device0_0:
> > dev_phase2: dev southbridge:
> > dev_phase2: dev domain0:
> > Phase 2: Done.
>
> I just realized there was no dts in northbridge/amd/geodelx ... this
> is a possible problem.
>
> Add a dts for the geode northbridge.
>
> Signed-off-by: Ronald G. Minnich

If it works or at least improves the situation, the patch is
Acked-by: Carl-Daniel Hailfinger

Please try to be more verbose in your changelog.

Regards,
Carl-Daniel

[LinuxBIOS] PATCH: lx car that returns from disable_car

[ron minnich]

On Jan 16, 2008 5:26 PM, Carl-Daniel Hailfinger
> Acked-by: Carl-Daniel Hailfinger
>
> Please try to be more verbose in your changelog.

Committed revision 555.

I tried for a better message.

It still did not make it go better :-(

Looking at it now.

ron