RS780 dev3 detection

[Qing Pei Wang]

hi all,
  tilapila support both dual slot and single slot. The difference should be
detected by the existence of dev3. Some other RS780 mainboard has
the same function. The patch added the function to make these boards work
smoothly.

Signed-off-by: Wang Qing Pei

[Bao, Zheng]

Acked-by: Zheng Bao [e-mail]

________________________________

From: [e-mail]
[mailto:[e-mail]] On Behalf Of Qing Pei Wang
Sent: Monday, August 16, 2010 3:18 PM
To: Coreboot
Subject: [coreboot] RS780 dev3 detection

hi all,
  tilapila support both dual slot and single slot. The difference should
be detected by the existence of dev3. Some other RS780 mainboard has 
the same function. The patch added the function to make these boards
work smoothly.

Signed-off-by: Wang Qing Pei

[Bao, Zheng]

Acked-by: Zheng Bao

________________________________________
From: [e-mail] [mailto:[e-mail]] On Behalf Of Qing Pei Wang
Sent: Monday, August 16, 2010 3:18 PM
To: Coreboot
Subject: [coreboot] RS780 dev3 detection

hi all,
  tilapila support both dual slot and single slot. The difference should be detected by the existence of dev3. Some other RS780 mainboard has 
the same function. The patch added the function to make these boards work smoothly.

Signed-off-by: Wang Qing Pei

[Rudolf Marek]

Hi Quing Pei,

Do you have an idea if the Asrock board can have similar autodectection? 
Please can you explain what it does?

Thanks,
Rudolf

[Qing Pei Wang]

hi Rudolf,
   I am not much familiar with Asrock board, but you can try to use
is_dev3_present which located in amd/tilapia/mainboard.c to detect the
configuration.

On Mon, Aug 16, 2010 at 7:26 PM, Rudolf Marek  wrote:
> Hi Quing Pei,
>
> Do you have an idea if the Asrock board can have similar autodectection?
> Please can you explain what it does?
>
> Thanks,
> Rudolf

[Rudolf Marek]

Hi, yes but what the code does? What is the philosophy behind it...

Thanks,
Rudolf

[Bao, Zheng]

The tilapia can configured as dual slot or single slot. It depends on
whether one device is behind the gfx slot 2(dev 3). And tilapia provides
a easy way to detect this, instead of the whole training process. In
this case, we define the gfx_dual_slot as 2, which means it should be
detected.

Zheng
> -----Original Message-----
> From: [e-mail]

[mailto:[e-mail]]
> On Behalf Of Rudolf Marek
> Sent: Monday, August 16, 2010 7:59 PM
> To: Qing Pei Wang
> Cc: Coreboot
> Subject: Re: [coreboot] RS780 dev3 detection
>
> Hi, yes but what the code does? What is the philosophy behind it...
>
> Thanks,
> Rudolf

[Stefan Reinauer]

On 8/16/10 9:18 AM, Qing Pei Wang wrote:
> hi all,
>   tilapila support both dual slot and single slot. The difference
> should be detected by the existence of dev3. Some other RS780
> mainboard has
> the same function. The patch added the function to make these boards
> work smoothly.
>
> Signed-off-by: Wang Qing Pei <[e-mail]
> >

r5714

[Peter Stuge]

Stefan Reinauer wrote:
> On 8/16/10 9:18 AM, Qing Pei Wang wrote:
> > hi all,
> >   tilapila support both dual slot and single slot. The difference
> > should be detected by the existence of dev3. Some other RS780
> > mainboard has the same function. The patch added the function to
> > make these boards work smoothly.
> >
> > Signed-off-by: Wang Qing Pei

Nice!

//Peter