With the addition of the Tyan board today, we've reached our 9th platform supported in buildrom (yay!). Its starting to get a little crowded in there, so lets start categorizing the boards to make the list more manageable.
I wanted to do it on a CPU basis, but IRC convinced me to do it by board vendor, so here it is.
Jordan
* Jordan Crouse jordan.crouse@amd.com [071025 01:59]:
With the addition of the Tyan board today, we've reached our 9th platform supported in buildrom (yay!). Its starting to get a little crowded in there, so lets start categorizing the boards to make the list more manageable.
I wanted to do it on a CPU basis, but IRC convinced me to do it by board vendor, so here it is.
Jordan
Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
[BULDROM] Further categorize boards by vendor
Buildrom is getting to successful for its own good.. :) Categorize the boards by vendor to make them easier to find.
Signed-off-by: Jordan Crouse jordan.crouse@amd.com
Acked-by: Stefan Reinauer stepan@coresystems.de
On Wed, Oct 24, 2007 at 05:59:12PM -0600, Jordan Crouse wrote:
Buildrom is getting to successful for its own good.. :) Categorize the boards by vendor to make them easier to find.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Just some small cosmetics before you commit:
Signed-off-by: Jordan Crouse jordan.crouse@amd.com Index: buildrom-devel/config/platforms/Config.in =================================================================== --- buildrom-devel.orig/config/platforms/Config.in 2007-10-24 17:23:52.000000000 -0600 +++ buildrom-devel/config/platforms/Config.in 2007-10-24 17:38:37.000000000 -0600 @@ -1,6 +1,31 @@ menu "Platform Configuration"
choice
- prompt "Vendor for the platform target"
- default VENDOR_AMD
- help
Select a vendor category for the target you want to build for
Missing full stop.
+config VENDOR_AMD
- bool "AMD"
+config VENDOR_ARTEC
- bool "Artec Group"
+config VENDOR_DIGITALLOGIC
- bool "Digital Logic"
+config VENDOR_GIGABYTE
- bool "Gigabyte"
GIGABYTE, as per website.
+config VENDOR_PCENGINES
- bool "PC Engines"
+config VENDOR_TYAN
- bool "Tyan"
+endchoice
+choice prompt "Platform target for the ROM" default PLATFORM_NORWICH help @@ -8,38 +33,47 @@
config PLATFORM_NORWICH bool "AMD Geode LX 'Norwich'"
gg select PLATFORMdepends VENDOR_AMD
config PLATFORM_DBE61 bool "Artec Group dbe61"
DBE61, I think.
depends VENDOR_ARTEC select PLATFORM
config PLATFORM_ALIX1C bool "PC Engines ALIX1.C"
depends VENDOR_PCENGINES select PLATFORM
config PLATFORM_MSM800SEV bool "Digital Logic msm800sev"
"Advanced Digital Logic MSM800SEV", as per website.
depends VENDOR_DIGITALLOGIC select PLATFORM
config PLATFORM_DB800 bool "AMD DB800"
- depends VENDOR_AMD select PLATFORM
config PLATFORM_M57SLI bool "Gigabyte M57SLI"
GIGABYTE GA-M57SLI-S4
depends VENDOR_GIGABYTE select PLATFORM
config PLATFORM_TYAN_S2882 bool "Tyan S2882"
depends VENDOR_TYAN select PLATFORM
config PLATFORM_TYAN_S2891 bool "Tyan S2891"
depends VENDOR_TYAN select PLATFORM
config PLATFORM_SERENGETI_CHEETAH bool "AMD Serengeti_Cheetah"
Debatable, but I'd prefer "Serengeti Cheetah" or "Serengeti-Cheetah", whichever is closer to the "official" product name.
depends VENDOR_AMD select PLATFORM
endchoice endmenu
Uwe.
Uwe brings up a good point - all the cosmetic suggestions he made were not in the most recent patch, but were already in the code base. When adding a new platform, please make sure you add the correct marketing name (and this goes for LinuxBIOSv3 too, since the paradigm is similar).
Thanks, Jordan
On 25/10/07 15:14 +0200, Uwe Hermann wrote:
On Wed, Oct 24, 2007 at 05:59:12PM -0600, Jordan Crouse wrote:
Buildrom is getting to successful for its own good.. :) Categorize the boards by vendor to make them easier to find.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Just some small cosmetics before you commit:
Signed-off-by: Jordan Crouse jordan.crouse@amd.com Index: buildrom-devel/config/platforms/Config.in =================================================================== --- buildrom-devel.orig/config/platforms/Config.in 2007-10-24 17:23:52.000000000 -0600 +++ buildrom-devel/config/platforms/Config.in 2007-10-24 17:38:37.000000000 -0600 @@ -1,6 +1,31 @@ menu "Platform Configuration"
choice
- prompt "Vendor for the platform target"
- default VENDOR_AMD
- help
Select a vendor category for the target you want to build for
Missing full stop.
+config VENDOR_AMD
- bool "AMD"
+config VENDOR_ARTEC
- bool "Artec Group"
+config VENDOR_DIGITALLOGIC
- bool "Digital Logic"
+config VENDOR_GIGABYTE
- bool "Gigabyte"
GIGABYTE, as per website.
+config VENDOR_PCENGINES
- bool "PC Engines"
+config VENDOR_TYAN
- bool "Tyan"
+endchoice
+choice prompt "Platform target for the ROM" default PLATFORM_NORWICH help @@ -8,38 +33,47 @@
config PLATFORM_NORWICH bool "AMD Geode LX 'Norwich'"
gg select PLATFORMdepends VENDOR_AMD
config PLATFORM_DBE61 bool "Artec Group dbe61"
DBE61, I think.
depends VENDOR_ARTEC select PLATFORM
config PLATFORM_ALIX1C bool "PC Engines ALIX1.C"
depends VENDOR_PCENGINES select PLATFORM
config PLATFORM_MSM800SEV bool "Digital Logic msm800sev"
"Advanced Digital Logic MSM800SEV", as per website.
depends VENDOR_DIGITALLOGIC select PLATFORM
config PLATFORM_DB800 bool "AMD DB800"
- depends VENDOR_AMD select PLATFORM
config PLATFORM_M57SLI bool "Gigabyte M57SLI"
GIGABYTE GA-M57SLI-S4
depends VENDOR_GIGABYTE select PLATFORM
config PLATFORM_TYAN_S2882 bool "Tyan S2882"
depends VENDOR_TYAN select PLATFORM
config PLATFORM_TYAN_S2891 bool "Tyan S2891"
depends VENDOR_TYAN select PLATFORM
config PLATFORM_SERENGETI_CHEETAH bool "AMD Serengeti_Cheetah"
Debatable, but I'd prefer "Serengeti Cheetah" or "Serengeti-Cheetah", whichever is closer to the "official" product name.
depends VENDOR_AMD select PLATFORM
endchoice endmenu
Uwe.
http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On 25/10/07 15:14 +0200, Uwe Hermann wrote:
On Wed, Oct 24, 2007 at 05:59:12PM -0600, Jordan Crouse wrote:
Buildrom is getting to successful for its own good.. :) Categorize the boards by vendor to make them easier to find.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
r50