[PATCH] improve debug output for not matching Vendor/Device ID in pci_rom.c

[Pattrick Hueper]

Hi,

i came across this error during YABEL debugging, and adding the
expected values to me makes sense to really see that this is an error.

Cheers, Patty

Signed-off-by: Pattrick Hueper 
---
 device/pci_rom.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/device/pci_rom.c b/device/pci_rom.c
index 443f52b..75e08e4 100644
--- a/device/pci_rom.c
+++ b/device/pci_rom.c
@@ -113,8 +113,8 @@ struct rom_header *pci_rom_probe(struct device *dev)
           rom_data->vendor, rom_data->device);
    if (dev->id.pci.vendor != rom_data->vendor || dev->id.pci.device !=
rom_data->device) {
    	printk(BIOS_ERR,
-		       "Device or Vendor ID mismatch Vendor %04x, Device %04x\n",
-		       rom_data->vendor, rom_data->device);
+		       "Device or Vendor ID mismatch Vendor %04x, Device %04x,
expected: Vendor: %04x, Device %04x\n",
+		       rom_data->vendor, rom_data->device, dev->id.pci.vendor,
dev->id.pci.device);
    	return NULL;
    }

[Myles Watson]

On Tue, Dec 16, 2008 at 5:48 AM, Pattrick Hueper  wrote:
> Hi,
>
> i came across this error during YABEL debugging, and adding the
> expected values to me makes sense to really see that this is an error.http://www.coreboot.org/mailman/listinfo/coreboot

I agree.  I added the information in Rev 1072.  Thanks.

While I was there I got to wondering if we shouldn't error out if the
checksum doesn't match.  It seems dangerous (especially if we're not using
an emulator) to execute a ROM with an incorrect checksum.

Thanks,
Myles