Re: [coreboot] `DEBUG_INTEL_ME` (incorrectly) only selected for Intel BD82x6x

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 26.02.2014 04:24, mrnuke wrote:
> On Wednesday, February 19, 2014 11:06:40 PM Paul Menzel wrote:
> > looking through `src/console/Kconfig` I noticed
>
> You mean 'src/Kconfig' ?
> >             if SOUTHBRIDGE_INTEL_BD82X6X && DEFAULT_CONSOLE_LOGLEVEL_8
>
> This is a layering violation. We shouldn't have hardware-specific options in 
> top-level Kconfig. This should be moved to southbridge Kconfig, and not depend 
> on LOGLEVEL. Maybe we need to move ME handling to a common dir and handle the 
> Kconfigs there.
> > which seems odd as currently other chipsets needing the Intel Management
> > Engine were submitted.
> >     $ git grep DEBUG_INTEL_ME
> >     [...]
>
> Smells like copypasta. Yet another reason to consider unifying ME handling 
> across southbridges.

Don't. This particular code is a good example why it shouldn't be done.
On Ibexpeak this code (extended status print) would timeout.