I thought the next step was normal in CBFS. This doesn't seem to get us closer to that.
The "normal" image is executed with "jmp __normal_image". __normal_image is defined as 8 bytes before the first byte of fallback/coreboot.rom (the reset vector of the normal image).
Yes. I thought we were going to do something like
cbfs_call("normal"); //totally made up.
Which would look in cbfs for the normal image, decompress it if necessary, and call it.
What you're doing makes the normal image work again, but doesn't put it into CBFS.
Thus, we actually have to change the coreboot.rom's sizes manually (to decrease the bootblock's size) if we want normal to work - we don't do that so far, we simply use coreboot.strip.
Right.
Until non-CBFS images are gone per board, or for all boards?
I intend to kill the non-CBFS infrastructure some weeks after everything is officially moved over. This patch fixes the last known (to me) regression of CBFS over non-CBFS. So the timeline would be:
- this patch + changes to CBFS boards to build correctly
- patch to get all boards over to CBFS (test as many of them as
possible: I can provide testing for 4 boards by three cpu/chipset vendors + qemu)
- wait some weeks
- remove non-CBFS code
This is the place where you put in cbfs_call("normal") ? Thanks for the overview.
Acked-by: Myles Watson mylesgw@gmail.com
Thanks, Myles