Hello Marc,
I reviewed the code and it looks good. But real testing shows an issue with soft restart (UBUNTU). The southbridge seems to hang. Coreboot stops because it could not read the SPI ROM of DIMM Module. Please see logs. The cold start log also reports errors but will successful boot Ubuntu.
Regards
Wolfgang
-----Ursprüngliche Nachricht----- Von: gerrit code review [mailto:gerrit@coreboot.org] Gesendet: Freitag, 20. Januar 2012 00:52 An: Wolfgang Kamp - datakamp Cc: Kerry Sheh Betreff: Change in coreboot[master]: Inagua: Synchronize AMD/inagua mainboard.
From Marc Jones marcj303@gmail.com:
Hello Wolfgang Kamp,
I'd like you to do a code review. Please visit
http://review.coreboot.org/542
to review the following change.
Change subject: Inagua: Synchronize AMD/inagua mainboard. .....................................................................
Inagua: Synchronize AMD/inagua mainboard.
AMD/persimmon mainboard code is derived from AMD/inagua mainbard. Persimmom update a lot in the last few month, sync these modification to inagua.
Change-Id: Ia038e5a2b9550fe81bb075f31e30b98354758e9e Signed-off-by: Kerry Sheh shekairui@gmail.com Signed-off-by: Kerry Sheh kerry.she@amd.com --- M src/mainboard/amd/inagua/BiosCallOuts.c M src/mainboard/amd/inagua/BiosCallOuts.h M src/mainboard/amd/inagua/Kconfig M src/mainboard/amd/inagua/Makefile.inc M src/mainboard/amd/inagua/OptionsIds.h M src/mainboard/amd/inagua/PlatformGnbPcie.c D src/mainboard/amd/inagua/acpi/ssdt2.asl D src/mainboard/amd/inagua/acpi/ssdt3.asl D src/mainboard/amd/inagua/acpi/ssdt4.asl D src/mainboard/amd/inagua/acpi/ssdt5.asl M src/mainboard/amd/inagua/acpi_tables.c M src/mainboard/amd/inagua/agesawrapper.c M src/mainboard/amd/inagua/agesawrapper.h M src/mainboard/amd/inagua/buildOpts.c M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/inagua/dimmSpd.c M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/inagua/fadt.c M src/mainboard/amd/inagua/get_bus_conf.c M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mainboard.c M src/mainboard/amd/inagua/mptable.c M src/mainboard/amd/inagua/platform_cfg.h M src/mainboard/amd/inagua/romstage.c 24 files changed, 249 insertions(+), 717 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/542/2 -- To view, visit http://review.coreboot.org/542 To unsubscribe, visit http://review.coreboot.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia038e5a2b9550fe81bb075f31e30b98354758e9e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kerry Sheh shekairui@gmail.com Gerrit-Reviewer: Kerry Sheh shekairui@gmail.com Gerrit-Reviewer: Wolfgang Kamp wmkamp@datakamp.de Gerrit-Reviewer: build bot (Jenkins)