Re: [coreboot] [PATCH] cleanup x86emu without yabel

[Stefan Reinauer]

Myles Watson wrote:
> +#ifdef CONFIG_COREBOOT_V2
> dev = dev_find_device(X86_DX, X86_CX, dev);
>
> This looks wrong.  I know it really isn't part of the patch, but isn't
> CONFIG_COREBOOT_V2 always defined?  I guess it isn't in v3...

It should be always defined in v2, and never in v2... Not sure if things
changed meanwhile, but that part of the code is not new, just copied..

We could make v2 more similar to v3

svn mv src/include/console/* src/include

and

s/dev_find_device/dev_find_pci_device/

if you feel like we should drop the define.

(Or we just drop the define since x86emu is no longer shared with v3)

Stefan