On Sat, Oct 17, 2009 at 03:25:07PM +0200, svn@coreboot.org wrote:
Remove CONFIG_ from #defines that aren't config variables. Trivial.
Why this? Shouldn't they have been added to src/Kconfig (for example) instead?
Modified: trunk/coreboot-v2/src/arch/i386/init/car.S
--- trunk/coreboot-v2/src/arch/i386/init/car.S 2009-10-17 03:00:04 UTC (rev 4801) +++ trunk/coreboot-v2/src/arch/i386/init/car.S 2009-10-17 13:25:07 UTC (rev 4802) @@ -269,7 +269,7 @@
/* TODO: make this a config variable */ -#if CONFIG_CARTEST +#if CARTEST
This one, for example, should likely be an option in the "Debugging" menu, maybe only visible if EXPERT is enabled (will post EXPERT patch soon).
I personally think that _all_ options should be kconfig options (i.e. listed in a Kconfig file with some default). Whether or not they should also be visible in menuconfig is another issue and depends on the option, though.
Uwe.