7 Sep
2022
7 Sep
'22
3:20 p.m.
Implementation [1] of unit-tests build failures reporting is now available for review. With this change failing unit-tests builds are visible [2] in the Jenkins job status in the Test Results section.
[1] https://review.coreboot.org/c/coreboot/+/67372 [2]* https://qa.coreboot.org/job/coreboot-gerrit/215975/
* Link [2] might stop working soon as Jenkins is not keeping everything forever
--
Jakub
On Mon, Sep 5, 2022 at 5:33 PM Jakub Czapiga jacz@semihalf.com wrote:
>
> > We'd have to wrap the build process for the unit tests to report into
> > junit on error.
> >
> > tests/Makefile.inc already looks for JUNIT_OUTPUT. The target in
> > tests/Makefile.common for $($(1)-bin) would have to be extended to
> > create a report on build failure.
>
> It will not be enough. $($(1)-bin) target is responsible for linking test
> binary. $($(1)-objs) would also have to be extended to detect whether
> a particular file failed to compile.
>
> > The junit.xml target in payloads/libpayload/Makefile.inc might serve as
> > inspiration.
>
> Thanks for the tip. It will come in handy.
> I will try to find some time to extend unit-tests framework to support
> tests compilation failures reports in coreboot and libpayload makefiles.
>
> --
> Jakub