Re: [coreboot] [patch][msrtool] Add K8 MSRs

[Stefan Reinauer]

Marc Jones wrote:
> > > -const uint32_t msraddrbyname(const char *name) {
> > > +uint32_t msraddrbyname(const char *name) {
> >
> > Any reason for the const removal? The changelog doesn't say anything
> > about it
>
> That was to get it to compile with -Werror which is on by default. It
> didn't look like that really needed to be a const.

Does the const make sense at all? It seems odd to define the variable
integer return value of a function const. What's that supposed to be
good for?

Stefan