Keith Hui wrote:
Mark's suggestion is too good to not make a patch out of.
Ron, turns out your extra branching is not necessary. pnp_set_enable() only care if that argument is zero or not; it doesn't have to be 1.
The attached patch fixes this PnP device enabling, and solves the long standing issue of PS/2 keyboard (and mouse - I just tried with this patch and my mouse works! :-D ) not working with the entire P2B family of mainboards, and possibly all boards using the W83977TF/EF super I/O chips.
Cheers. And many thanks to Mark. Hope this is OK with you - me making a patch out of your suggestion.
Yes, this is great. If I'd had the time and access to the code I'd have done this, but my coreboot machines are in storage for a few weeks.
Signed-off-by: Keith Hui buurin@gmail.com
Acked-by: Mark Marshall mark.marshall@csr.com