On 11/04/08 01:23 +0200, Uwe Hermann wrote:
I'll let the usual suspects review and ACK buildrom code, just some small notes:
On Thu, Apr 10, 2008 at 04:43:20PM -0600, Jordan Crouse wrote:
Index: buildrom-devel/packages/libpayload/libpayload.mk
--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ buildrom-devel/packages/libpayload/libpayload.mk 2008-04-10 13:03:02.000000000 -0600 @@ -0,0 +1,88 @@
[...]
+ifeq ($(call custom-config-exists,libpayload), 1) +LIBPAYLOAD_CONFIG=$(call custom-config-name,libpayload) +else +ifeq ($(CONFIG_PLATFORM_GEODE),y) +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig +else +LIBPAYLOAD_CONFIG=$(PACKAGE_DIR)/libpayload/conf/defconfig.geode
Isn't the logic here inverted? Untested, but I'd assume the "defconfig.geode" would belong to the "CONFIG_PLATFORM_GEODE=y" part?
Oh, wow - that was dumb of me. Thanks for catching that.
+libpayload-config: | $(LIBPAYLOAD_SRC_DIR)/.config
Does this work? The '|' there looks strange, but maybe I'm missing something.
Its an "order" only flag. see: http://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html#Pr...
+ifeq ($(call custom-config-exists,libpayload), 1)
- @ cp -f $(call custom-config-name,libpayload) $(LIBPAYLOAD_SRC_DIR)/.config
+endif
- @ echo "Configure libpayload..."
- @ $(MAKE) -C $(LIBPAYLOAD_SRC_DIR) menuconfig
- @ echo
+ifeq ($(call custom-config-exists,libpayload),1)
- @ echo "Found an existing custom configuration file:"
- @ echo " $(call custom-config-name,libpayload)"
- @ echo "I've copied it back to the source directory for modification."
- @ echo "Remove the above file and re-run this comand if you want to create a new customer configuration from scratch for this payload/board."
comand -> command
All fixed.
Thanks. Jordan