Re: [coreboot] [PATCH] fix normal vs. fallback

[Myles Watson]

On Thu, Jul 8, 2010 at 11:56 AM, Patrick Georgi  wrote:
> Am 08.07.2010 19:50, schrieb Myles Watson:
> > BOOTBLOCK_NORMAL allows the user to use CMOS values to select which
> > image to boot.  This patch:
> > makes BOOTBLOCK_NORMAL depend on USE_OPTION_TABLE
>
> This would prevent the "old" scheme of building a fallback image (which
> is built first) with BOOTBLOCK_NORMAL and _no_ USE_OPTION_TABLE (so it
> uses the hardcoded defaults) and a normal image with USE_OPTION_TABLE.

So I probably went too far.  I should have made it depend on HAVE_OPTION_TABLE.
> > makes compilation of bootblock.inc depend on OPTION_TABLE_H
>
> How does this interact with BOOTBLOCK_SIMPLE builds without
> USE_OPTION_TABLE?

It shouldn't make a difference.  OPTION_TABLE_H is empty if there isn't one.

Thanks,
Myles