Re: [coreboot] [PATCH] fix 'AMD Fam10 code breaks with gcc 4.5.0'

[Patrick Georgi]

Am 03.09.2010 15:47, schrieb Flemming Richter Mikkelsen:
> gcc supports -Winline and this warning should, if not already, be
> enabled by default (in the Makefiles).

I doubt this option is really very useful. We often inline at places
where we advise it, but where there's no harm if it isn't inlined.
The code that requires that attribute _requires_ inlining.

Given that we use -Werror, -Winline (which is triggered by heuristics)
is a really bad idea in my opinion.

Regards,
Patrick