Re: [LinuxBIOS] [PATCH] Tyan S1846: Device tree fixes

[Stefan Reinauer]

* Uwe Hermann  [070529 06:37]:
> The static device tree of the Tyan S1846 was, um... totally bogus.
>
> I'm using the ide0_enble/ide1_enable variables now to enable IDE.
> Hm, what happens if those variables are not set at all in a Confib.lb
> file of some mainboard? Do they default to zero?
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Fix the static device tree of the Tyan S1846. Especially the
> Super I/O part was incorrect.
>
> Also, add ide0_enable/ide1_enable variables, and enable both the
> primary and secondary IDE interface per default.
> Signed-off-by: Uwe Hermann

I dont have the board, but I think it makes sense. Please someone else
intervent otherwise. I say:

Acked-by: Stefan Reinauer