-----Original Message----- From: Matt DeVillier matt.devillier@gmail.com Sent: Thursday, September 3, 2020 7:11 PM To: Desimone, Nathaniel L nathaniel.l.desimone@intel.com Cc: coreboot@coreboot.org Subject: Re: [coreboot] [RFC] Proposal to move all FSP 1.x binaries to "legacy" branch
support for FSP 1.0 was dropped, but FSP 1.1 is still used by Braswell and supported in coreboot master
That is good feedback, thank you!
the biggest issue would be that even if coreboot did entirely drop support for FSP 1.x in master, there would still be older tags/branches from which boards using FSP 1.x could be built, and moving those FSP binaries out of the master branch would break building of those boards without changes to the older coreboot branches to handle that, which would become quite tricky if one then needs to support pulling FSP from multiple branches
For Braswell and other FSP 1.1 projects on coreboot master branch this makes a lot of sense. The FSP submodule pointer will be continually updated, which would cause Braswell to break. But for maintenance branches and tags, the submodule pointer will point to an older version of FSP master branch where those binaries still existed. The maintenance branches can either stay on the older master SHA or update to the newer legacy branch SHA.
Based on your feedback and Jay's feedback, I will only move the FSP 1.0 binaries to the legacy branch, so that way the combination of coreboot master branch + FSP master branch continues to work. Maintenance branches and older tags will continue to work with older SHAs.
Thanks, Nate