Thanks, patch is committed in r2883.
On Sun, Oct 21, 2007 at 11:20:40PM +0200, Rudolf Marek wrote:
+static void host_enable(struct device *dev)
Would const struct device *dev work? It looks like dev is not being modified(?)
Perhaps yes, but lets change that later.
OK.
- res = new_resource(dev, K8T890_MMCONFIG_MBAR);
- res->size = 256 * 1024 * 1024;
Why hardcoded? Is it configurable or _must_ it be hardcoded this way? (sorry if I already asked that)
What exactly? The BAR addr is computed dynamically.
I meant the "256 * 1024 * 1024". Is this size fixed or configurable?
+/* please check the datasheet and traf_ctrl_enable before change! */ +#define K8T890_APIC_BASE 0xfecc0000
Um, "please check datasheet" is not going to happen without NDA, so please explain it here.
Well it cant be changed to arbitrary address, so this is the reason why the reg is static.
Yes, but please document which addresses are possible/valid (and in which cases).
Uwe.