Re: [LinuxBIOS] #70: fix util/getpir so that the output will compile

[Jon Dufresne]

Well doing a simple grep tells me that this function isn't universal,
however the majority of them define the function the way I did, which
is why I defined it that way. So no this is not universal.

I guess it is your call. If you want the standard function defined for
the developer and then if he/she wants can change it, or if you'd
prefer it not be defined at all. I don't see a strong argument either
way.

Jon

On 12/19/06, ron minnich  wrote:
> I'm not totally sure about this one. What we have done for a number of
> reasons is let each board define this function. I think it's for the
> usual reason -- some wacko board that breaks all the rules -- Jon, are
> you sure this works in ALL cases -- that every single board can use
> this standard function definition?
>
> thanks
>
> ron
>
> On 12/19/06, LinuxBIOS  wrote:
> > #70: fix util/getpir so that the output will compile
> > -----------------------------------------------------+----------------------
> >    Reporter:  Jon Dufresne   |          Owner:  somebody
> >        Type:  defect                                 |         Status:  new
> >    Priority:  major                                  |      Milestone:
> >   Component:  code                                   |        Version:  v2
> >    Keywords:                                         |   Dependencies:
> > Patchstatus:  there is no patch                      |
> > -----------------------------------------------------+----------------------
> >  The file "irq_table.c" created by getpir needs an additional funciton in
> >  order to compile in a project. I patched getpir so this is taken care of
> >  automatically. I used a few different boars as an example