Re: [coreboot] [PATCH] fix object/driver confusion of all northbridge code

[Corey Osgood]

On Tue, Mar 24, 2009 at 12:06 PM, Peter Stuge  wrote:
> Stefan Reinauer wrote:
> > Every object file with a struct pci_driver ... __pci_driver needs to
> > be marked as "driver" instead of "object" in order to get the init
> > code actually executed.
> >
> > This patch fixes up all northbridges that did not do this before.
> >
> > Signed-off-by: Stefan Reinauer
>
> Acked-by: Peter Stuge
>
> How come we have not noticed this before? Do these NB drivers not do
> anything critical?

Please hold off until tomorrow on committing this. IIRC I tried this with
cn700 and something broke, but I don't remember what or why.

Thanks,
Corey