Re: [LinuxBIOS] [PATCH] Add support for the NSC PC87309 Super I/O

[Stefan Reinauer]

* Uwe Hermann  [070331 00:11]:
> Index: src/superio/nsc/pc87309/pc87309.h
>
> --- src/superio/nsc/pc87309/pc87309.h	(Revision 0)
> +++ src/superio/nsc/pc87309/pc87309.h	(Revision 0)
> @@ -0,0 +1,30 @@
> +#define PC87309_FDC  0x00	/* Floppy */
> +#define PC87309_PP   0x01	/* Parallel port */
> +#define PC87309_SP2  0x02	/* Com2 / IR */
> +#define PC87309_SP1  0x03	/* Com1 */
> +#define PC87309_PM   0x04	/* Power management */
> +#define PC87309_KBCM 0x05	/* Mouse */
> +#define PC87309_KBCK 0x06	/* Keyboard */

Since these defines are only ever used in one single file, it should not
be an extra include file, but part of superio.c

In order to make the code more reusable I suggest also dropping the
PC87309_ prefix