Re: [LinuxBIOS] [PATCH] BCOM Winnet100 support

[Uwe Hermann]

On Tue, Oct 09, 2007 at 09:59:50PM +0200, Juergen Beisert wrote:
> its really hard to make you happy...

Sorry :)
> > > +default CONFIG_VIDEO_MB=2
> >
> > Please also add these as comments to targets/.../Config.lb,
> > as users are likely to want to modify them.
>
> Sorry, I have no idea what you want me to do here.

Ah, I meant to just add them to targets/.../Config.lb (in addition
to Options.lb). I don't think we do this everywhere, but I have the
feeling that targets/.../Config.lb is meant for user changes (and
Options.lb rather not in the normal case). I might be wrong, though.

(Config.lb overrides Options.lb btw)
> > If you're not using the CMOS option table, you can drop the cmos.layout
> > file.
>
> Without the cmos.layout file I now get:
>
> [...]
> make[1]: Entering directory 
> `/OSELAS/bsp/OSELAS.BSP-JB-GeoTerm-trunk/temp/LinuxBIOSv2/targets/bcom/winnet100/winnet100/normal'
> make[1]: *** No rule to make target 
> `/OSELAS.BSP-JB-GeoTerm-trunk/LinuxBIOSv2/src/mainboard/bcom/winnet100/cmos.layout', 
> needed by `option_table.h'.  Stop.
>
> No idea why.

Ah, yes, sorry. You have to drop the dependency on option_table.h in
src/.../Config.lb like this:

makerule ./auto.E
        # depends       "$(MAINBOARD)/auto.c option_table.h ./romcc"
        depends "$(MAINBOARD)/auto.c ./romcc"
        action  "./romcc -E -O -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/auto.c -o $@"
end
makerule ./auto.inc
        # depends "$(MAINBOARD)/auto.c option_table.h ./romcc"
        depends "$(MAINBOARD)/auto.c ./romcc"
        action  "./romcc -O -I$(TOP)/src -I. $(CPPFLAGS) $(MAINBOARD)/auto.c -o $@"
end

I've already done that before the commit, the code builds fine for me now.

Uwe.