Re: [coreboot] v3 Kontron warnings

[Uwe Hermann]

On Wed, Dec 10, 2008 at 09:57:21AM -0700, Myles Watson wrote:
> This patch fixes some warnings in the Kontron build and a little bit of
> whitespace.
>
> Signed-off-by: Myles Watson
>
> Thanks,
> Myles
> Index: svn/northbridge/intel/i945/raminit.c
>
> --- svn.orig/northbridge/intel/i945/raminit.c
> +++ svn/northbridge/intel/i945/raminit.c
> @@ -1070,7 +1070,7 @@ static void sdram_rcomp_buffer_strength_
>    };
>
> const u8 * strength_multiplier;
> const u8* const * slew_group_lookup;
> const u8 * slew_group_lookup;

That should be
> const u8 *slew_group_lookup;

rather.
> int idx;
>
> /* Set Strength Multipliers */
> Index: svn/southbridge/intel/i82801gx/pci.c
> ===================================================================
> --- svn.orig/southbridge/intel/i82801gx/pci.c
> +++ svn/southbridge/intel/i82801gx/pci.c
> @@ -57,7 +57,6 @@ static void pci_init(struct device *dev)
>  static void ich_pci_dev_enable_resources(struct device *dev)
>  {
>    const struct pci_operations *ops;
>
> u16 command;
>
> /* Set the subsystem vendor and device id for mainboard devices */
> ops = ops_pci(dev);
>
> @@ -72,6 +71,7 @@ static void ich_pci_dev_enable_resources
>    }
>
> #if 0
> u16 command;
> /* If we write to PCI_COMMAND, on some systems
> this will cause the ROM and APICs not being visible
> anymore.
>
> @@ -103,7 +103,7 @@ static void ich_pci_bus_enable_resources
>    enable_childrens_resources(dev);
>  }
>
> -static void set_subsystem(struct device * dev, u16 vendor, u16 device)
> +static void set_subsystem(struct device * dev, unsigned vendor, unsigned device)

Nope, u16 is the correct one, please don't change in this direction,
rather change more *int* to u8/u16/u32 where appropriate.
> {
>  #if 0
>    /* Currently disabled because it causes a "BAR 9" memory resource
> Index: svn/southbridge/intel/i82801gx/pcie.c
> ===================================================================
> --- svn.orig/southbridge/intel/i82801gx/pcie.c
> +++ svn/southbridge/intel/i82801gx/pcie.c
> @@ -67,7 +67,7 @@ static void pci_init(struct device *dev)
>    printk(BIOS_DEBUG, "    PMLU32 = 0x%08x\n", reg32);
>  }
>
> -static void set_subsystem(struct device * dev, u16 vendor, u16 device)
> +static void set_subsystem(struct device * dev, unsigned vendor, unsigned device)

Ditto.
> {
>    u32 pci_id;
> Index: svn/mainboard/kontron/986lcd-m/stage1.c
>
> --- svn.orig/mainboard/kontron/986lcd-m/stage1.c
> +++ svn/mainboard/kontron/986lcd-m/stage1.c
> @@ -207,7 +207,6 @@ void hardware_stage1(void)
>  {
>    void 	early_superio_config_w83627thg(void);
>    void 	ich7_enable_lpc(void);
> int boot_mode = 0;

Not used/needed?

Uwe.