Author: hailfinger Date: 2009-05-05 00:33:50 +0200 (Tue, 05 May 2009) New Revision: 459
Modified: trunk/chipset_enable.c Log: Force enabling SPI mode for SB600 is a bad idea and leads to hangs.
Only access LPC ROM if we boot via LPC ROM. Only access SPI ROM if we boot via SPI ROM. The code to force enable SPI is commented out in case someone wants to reenable it for a particular board with LPC and SPI flash.
Signed-off-by: Zheng Bao zheng.bao@amd.com Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Modified: trunk/chipset_enable.c =================================================================== --- trunk/chipset_enable.c 2009-05-04 21:03:59 UTC (rev 458) +++ trunk/chipset_enable.c 2009-05-04 22:33:50 UTC (rev 459) @@ -680,8 +680,16 @@ flashbus = BUS_TYPE_SB600_SPI;
/* Enable SPI ROM in SB600 PM register. */ + /* If we enable SPI ROM here, we have to disable it after we leave. + * But how can we know which ROM we are going to handle? So we have + * to trade off. We only access LPC ROM if we boot via LPC ROM. And + * only SPI ROM if we boot via SPI ROM. If you want to do it crossly, + * you have to use the code below. + */ + /* OUTB(0x8f, 0xcd6); OUTB(0x0e, 0xcd7); + */
return 0; }