Re: [coreboot] [PATCH] Set the register based on the ROMSIZE

[Peter Stuge]

Patrick Georgi wrote:
> > Set the register based on the ROMSIZE.

..
> How about
> pci_write_config16(dev, 0x6c,
> 0x10000-(max(512,CONFIG_COREBOOT_ROMSIZE_KB)>>6));
> instead?

I have a greater problem with this;

It assumes that one image will always go into one and the same size
of flash chip.

We can not support growing or shrinking of CBFS if we would like to,
and hotswapping flash chips with larger size does not work.

I would personally prefer using the largest possible value on all
chipsets.

//Peter