Am 01.03.2010 17:23, schrieb Myles Watson:
However, this does not fix the bug in our stack size calculation. I'm not quite sure if the patch does the right thing, but it should be close.
I don't think we need to make the SMP check. Can't we just put in an
assert
that checks for RAMBASE < 0xa0000 and eheap > 0xa0000? One large stack could just as easily break this.
True. Attached patch might do this (only moderately tested)
Acked-by: Myles Watson mylesgw@gmail.com
I think the only reason why we can't get rid of RAMBASE <1M completely is a couple of boards (Via based iirc) that have their own vgabios.c that breaks with RAMBASE >1M
The other RAMBASE we sometimes use (mostly on AMD boards) is RAMBASE==2M
- what was the rationale for that again?
I don't know. I can't see a reason for it.
With those two gone, we could hide RAMBASE somewhere in Kconfig or eliminate it completely.
Wasn't there a board with RAMBASE at 32 M too?
Thanks, Myles