Patch looks good (excluding comments already made), with one side thought: Looks like the UARTS are on the SuperIo device, a-la db800, but there no call to disable_internal_uarts? It may be a nicety, but it stops any potential issues with early debug? Cheers, Edwin
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Patrick Georgi Sent: 12 February 2010 08:15 To: coreboot@coreboot.org Subject: Re: [coreboot] resubmit - patch for Win Enterprises PL-6064/65 support
Am 12.02.2010 00:25, schrieb ron minnich:
I thought we were trying to get away from this kind of thing. Why is it still there?
Not quite there yet. I'll handle all boards that are in the tree when I get to removing that.
Patrick
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot