Nikolay Petukhov wrote:
2008/3/13, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net:
Maybe call it from mainboard.c, but keep the function inside the cs5536 code.
Maybe then so.
diff -Nru coreboot-v2-3132/src/southbridge/amd/cs5536/chip.h coreboot-v2-3132-beep/src/southbridge/amd/cs5536/chip.h --- coreboot-v2-3132/src/southbridge/amd/cs5536/chip.h 2008-01-18 15:35:56.000000000 +0500 +++ coreboot-v2-3132-beep/src/southbridge/amd/cs5536/chip.h 2008-03-14 11:17:02.000000000 +0500 @@ -39,6 +39,7 @@ unsigned char com2_enable; /* enable COM2 */ unsigned int com2_address; /* e.g. 0x2F8 */ unsigned int com2_irq; /* e.g. 3 */
unsigned char speaker_enable; /* enable speaker */ unsigned int unwanted_vpci[MAX_UNWANTED_VPCI]; /* thefollowing allow you to disable unwanted virtualized PCI devices */
This is ok but it will break all the geode platforms. There will need to be a follow-on patch to add speaker_enable to each mainboard Config.lb.
If you (or someone else) are interested you could make this even more generic to do any mainboard specific GPIO setup. But, this is probably good enough for most if not all 5536 platforms.
Marc