Re: [coreboot] [PATCH] Factor out common CAR asm snippets

[ron minnich]

On Sat, Oct 2, 2010 at 9:43 AM, Kevin O'Connor  wrote:
> I think the code is easier to read when it is all right there.  The
> CAR code is doing something very complex - trying to abstract out a
> few minor operations I think could further obscure what is occurring.

I agree with Kevin on this one. The CAR code is basically write-once.
It changes almost never. Rules about common code don't really apply
quite so much.

I find the non-abstracted version much easier to understand.

ron