Re: [coreboot] [PATCH] Don't loop endlessly in get_pbus

[Carl-Daniel Hailfinger]

On 05.03.2009 16:31, Marc Jones wrote:
> On Tue, Mar 3, 2009 at 4:48 PM, Carl-Daniel Hailfinger
>  wrote:
> > If get_pbus() is called for a device which has no parent/ancestor bus
> > with nonzero PCI bus operations, get_pbus() will get stuck in a silent
> > endless loop.
> > Detect the endless loop and break out with an error message.
> >
> > Such a situation can happen if the device tree is not yet
> > initialized/walked completely.
> >
> > This fixes the unexplainable hang if pci_{read,write}_config{8,16,32}was
> > used in early mainboard code for the AMD DBM690T. Instead, the code will
> > now die() with a meaningful error message.
> >
> > Thanks to Ward Vandewege for testing my patches to track down that bug.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Marc Jones

Thanks, r3972.

Regards,
Carl-Daniel