Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
3 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 1400227: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 94 in mp_startup_this_ap()
________________________________________________________________________________________________________ *** CID 1400227: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 94 in mp_startup_this_ap() 88 89 static efi_return_status_t mp_startup_this_ap(const 90 efi_pei_services **ignored1, efi_pei_mp_services_ppi *ignored2, 91 efi_ap_procedure procedure, efi_uintn_t processor_number, 92 efi_uintn_t timeout_usec, void *argument) 93 {
CID 1400227: Control flow issues (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "cpu_index() < 0UL".
94 if (cpu_index() < 0) 95 return FSP_DEVICE_ERROR; 96 97 if (processor_number > get_cpu_count()) 98 return FSP_NOT_FOUND; 99
** CID 1400226: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 48 in mp_get_processor_info()
________________________________________________________________________________________________________ *** CID 1400226: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 48 in mp_get_processor_info() 42 43 static efi_return_status_t mp_get_processor_info(const 44 efi_pei_services **ignored1, efi_pei_mp_services_ppi *ignored2, 45 efi_uintn_t processor_number, 46 efi_processor_information *processor_info_buffer) 47 {
CID 1400226: Control flow issues (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "cpu_index() < 0UL".
48 if (cpu_index() < 0) 49 return FSP_DEVICE_ERROR; 50 51 if (processor_info_buffer == NULL) 52 return FSP_INVALID_PARAMETER; 53
** CID 1400225: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 74 in mp_startup_all_aps()
________________________________________________________________________________________________________ *** CID 1400225: Control flow issues (NO_EFFECT) /src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c: 74 in mp_startup_all_aps() 68 69 static efi_return_status_t mp_startup_all_aps(const 70 efi_pei_services **ignored1, efi_pei_mp_services_ppi *ignored2, 71 efi_ap_procedure procedure, efi_boolean_t ignored3, 72 efi_uintn_t timeout_usec, void *argument) 73 {
CID 1400225: Control flow issues (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "cpu_index() < 0UL".
74 if (cpu_index() < 0) 75 return FSP_DEVICE_ERROR; 76 77 if (procedure == NULL) 78 return FSP_INVALID_PARAMETER; 79
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...