On 14.03.2008 15:41, Ward Vandewege wrote:
On Fri, Mar 14, 2008 at 03:36:47PM +0100, Carl-Daniel Hailfinger wrote:
On 14.03.2008 15:23, Ward Vandewege wrote:
On Fri, Mar 14, 2008 at 02:52:25PM +0100, Carl-Daniel Hailfinger wrote:
Testers wanted for all ICH versions!
Prepare for ICH7/ICH8 SPI support by adding some debugging for all ICH* chipsets. Functionality (except printing) should be unchanged.
My laptop (Dell 1420N) has ICH8:
# lspci -nn 00:1f.0 ISA bridge [0601]: Intel Corporation 82801HEM (ICH8M) LPC Interface Controller [8086:2815] (rev 02)
Thanks. Please try this new patch:
That's better:
# ./flashrom Calibrating delay loop... OK. No coreboot table found. Found chipset "Intel ICH8M", enabling flash write... Root Complex Base Address Register = 0xfed18000 GCS address = 0xfed1b410 GCS = 0x60 SPIBAR = 0xfed1b020 SPI Read Configuration: prefetching enabled, caching enabled, BIOS Lock Enable: disabled, BIOS Write Enable: disabled, BIOS_CNTL is 0x8 OK. WARNING: size: 0 -> 4096 (page size) WARNING: size: 0 -> 4096 (page size) WARNING: size: 0 -> 4096 (page size) WARNING: size: 0 -> 4096 (page size) WARNING: size: 0 -> 4096 (page size) No EEPROM/flash device found.
Thanks! Next try (with flashrom -V please):
Index: flashrom-ich7/chipset_enable.c =================================================================== --- flashrom-ich7/chipset_enable.c (Revision 3143) +++ flashrom-ich7/chipset_enable.c (Arbeitskopie) @@ -30,6 +30,7 @@ #include <stdlib.h> #include <sys/types.h> #include <sys/stat.h> +#include <sys/mman.h> #include <fcntl.h> #include <unistd.h> #include "flash.h" @@ -139,8 +140,8 @@ }
/* - * See ie. page 375 of "Intel ICH7 External Design Specification" - * http://download.intel.com/design/chipsets/datashts/30701302.pdf + * See ie. page 375 of "Intel I/O Controller Hub 7 (ICH7) Family Datasheet" + * http://download.intel.com/design/chipsets/datashts/30701303.pdf */ static int enable_flash_ich(struct pci_dev *dev, const char *name, int bios_cntl) @@ -153,6 +154,10 @@ */ old = pci_read_byte(dev, bios_cntl);
+ printf("BIOS Lock Enable: %sabled, ", (old & (1 << 1)) ? "en" : "dis"); + printf("BIOS Write Enable: %sabled, ", (old & (1 << 1)) ? "en" : "dis"); + printf("BIOS_CNTL is 0x%x\n", old); + new = old | 1;
if (new == old) @@ -178,6 +183,50 @@ return enable_flash_ich(dev, name, 0xdc); }
+static int enable_flash_ich_dc_spi(struct pci_dev *dev, const char *name) +{ + uint8_t old, new, bbs; + uint32_t tmp, gcs; + void *rcba; + + /* Root Complex Base Address Register (RCBA) */ + tmp = pci_read_long(dev, 0xf0); + tmp &= 0xffffc000; + printf("Root Complex Base Address Register = 0x%x\n", tmp); + rcba = mmap(0, 0x3510, PROT_READ, MAP_SHARED, fd_mem, (off_t)tmp); + if (rcba == MAP_FAILED) { + perror("Can't mmap memory using " MEM_DEV); + exit(1); + } + printf("GCS address = 0x%x\n", tmp + 0x3410); + gcs = *(volatile uint32_t *)(rcba + 0x3410); + printf("GCS = 0x%x: ", gcs); + printf("BIOS Interface Lock-Down: %sabled, ", + (gcs & 0x1) ? "en" : "dis"); + bbs = (gcs >> 10) & 0x3; + printf("BOOT BIOS Straps: 0x%x (%s)\n", bbs, + (bbs == 0x3) ? "LPC" : ((bbs == 0x2) ? "PCI" : "SPI")); + printf("SPIBAR = 0x%x\n", tmp + 0x3020); + /* TODO: Dump the SPI config regs */ + munmap(rcba, 0x3510); + + old = pci_read_byte(dev, 0xdc); + printf("SPI Read Configuration: "); + new = (old >> 2) & 0x3; + switch (new) { + case 0: + case 1: + case 2: + printf("prefetching %sabled, caching %sabled, ", + (new & 0x2) ? "en" : "dis", (new & 0x1) ? "dis" : "en"); + break; + default: + printf("invalid prefetching/caching settings, "); + break; + } + return enable_flash_ich_dc(dev, name); +} + static int enable_flash_vt823x(struct pci_dev *dev, const char *name) { uint8_t val; @@ -524,13 +573,15 @@ {0x8086, 0x24d0, "Intel ICH5/ICH5R", enable_flash_ich_4e}, {0x8086, 0x2640, "Intel ICH6/ICH6R", enable_flash_ich_dc}, {0x8086, 0x2641, "Intel ICH6-M", enable_flash_ich_dc}, - {0x8086, 0x27b0, "Intel ICH7DH", enable_flash_ich_dc}, - {0x8086, 0x27b8, "Intel ICH7/ICH7R", enable_flash_ich_dc}, - {0x8086, 0x27b9, "Intel ICH7M", enable_flash_ich_dc}, - {0x8086, 0x27bd, "Intel ICH7MDH", enable_flash_ich_dc}, - {0x8086, 0x2810, "Intel ICH8/ICH8R", enable_flash_ich_dc}, - {0x8086, 0x2812, "Intel ICH8DH", enable_flash_ich_dc}, - {0x8086, 0x2814, "Intel ICH8DO", enable_flash_ich_dc}, + {0x8086, 0x27b0, "Intel ICH7DH", enable_flash_ich_dc_spi}, + {0x8086, 0x27b8, "Intel ICH7/ICH7R", enable_flash_ich_dc_spi}, + {0x8086, 0x27b9, "Intel ICH7M", enable_flash_ich_dc_spi}, + {0x8086, 0x27bd, "Intel ICH7MDH", enable_flash_ich_dc_spi}, + {0x8086, 0x2810, "Intel ICH8/ICH8R", enable_flash_ich_dc_spi}, + {0x8086, 0x2811, "Intel ICH8M-E", enable_flash_ich_dc_spi}, + {0x8086, 0x2812, "Intel ICH8DH", enable_flash_ich_dc_spi}, + {0x8086, 0x2814, "Intel ICH8DO", enable_flash_ich_dc_spi}, + {0x8086, 0x2815, "Intel ICH8M", enable_flash_ich_dc_spi}, {0x1106, 0x8231, "VIA VT8231", enable_flash_vt823x}, {0x1106, 0x3177, "VIA VT8235", enable_flash_vt823x}, {0x1106, 0x3227, "VIA VT8237", enable_flash_vt823x},