Re: [coreboot] [PATCH] Allow selecting the physical USB Debug Port on AMD SB700

[Peter Stuge]

Uwe Hermann wrote:
> Allow selecting the physical USB Debug Port on AMD SB700.
>
> The AMD SB700 allows changing the physical USB port to be used as
> USB Debug Port, implement support for this.
>
> Also, fix incorrect PCI device of the SB700 EHCI device. Actually, the
> SB700 has _two_ EHCI devices (D18:F2 and D19:F2), but for now we only use
> D18:F2. Our generic USBDEBUG code cannot handle multiple EHCI PCI devices
> currently, AFAICS.
>
> Hook up all SB700 boards to the CONFIG_USBDEBUG_DEFAULT_PORT facility.
>
> Untested, but should work.
>
> Signed-off-by: Uwe Hermann

Acked-by: Peter Stuge
> +++ src/mainboard/asrock/939a785gmh/romstage.c	(Arbeitskopie)
> +++ src/mainboard/gigabyte/ma78gm/romstage.c	(Arbeitskopie)
> +++ src/mainboard/gigabyte/ma785gmt/romstage.c	(Arbeitskopie)
> +++ src/mainboard/amd/mahogany/romstage.c	(Arbeitskopie)
> +++ src/mainboard/amd/mahogany_fam10/romstage.c	(Arbeitskopie)
> +++ src/mainboard/amd/tilapia_fam10/romstage.c	(Arbeitskopie)
> +++ src/mainboard/iei/kino-780am2-fam10/romstage.c	(Arbeitskopie)
> +++ src/mainboard/jetway/pa78vm5/romstage.c	(Arbeitskopie)
> +++ src/mainboard/asus/m4a785-m/romstage.c	(Arbeitskopie)

I hope we can get even more stuff out of romstage.

//Peter