On 16.01.2009 06:39, Li, Maggie wrote:
Acked-by: Maggie li Maggie.li@amd.com
Thanks, committed in r3868.
Sorry I thought it should be acked by Marc. He knows more about this part than me.
No need to be sorry. I appreciate that you tested and acked it.
Best regards Maggie li
Regards, Carl-Daniel
-----Original Message----- From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006@gmx.net] Sent: Friday, January 16, 2009 1:32 PM To: Li, Maggie Cc: Marc Jones; Rudolf Marek; Bao, Zheng; Coreboot Subject: Re: [coreboot] AMD DBM690T PowerNow table problems
Hi,
if anyone wants to ack this, I'll commit it.
Regards, Carl-Daniel
On 15.01.2009 07:42, Li, Maggie wrote:
Hi
I have tested it on my DBM690T board. It is ok.
Best regards Maggie li
-----Original Message----- From: coreboot-bounces+maggie.li=amd.com@coreboot.org [mailto:coreboot-bounces+maggie.li=amd.com@coreboot.org] On Behalf Of Carl-Daniel Hailfinger Sent: Thursday, January 15, 2009 12:35 PM To: Marc Jones Cc: Rudolf Marek; Bao, Zheng; Coreboot Subject: Re: [coreboot] AMD DBM690T PowerNow table problems
The DBM90T code sets bit 10 in _PSS as part of the control value, but bit 10 is part of NewVID. That means the resulting VID is wrong and causes the processor to crash. The Pistachio code has the same bug.
This patch fixes the wrong setting and changes control from a magic and incorrect unexplained value (0xE8202C00) to a combination of explained values and shifts which has the right value (0xE8202800).
It is tested on my machine and it survived 200 changes from minimum to maximum frequency every 100 ms under heavy load and under no load.
In the long term we want to consolidate all AMD FIDVID code into one generic library file.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net