Re: [coreboot] [PATCH] fix stage0_i586.S in v3

[Carl-Daniel Hailfinger]

On 04.04.2008 04:40, Stefan Reinauer wrote:
> The idea to this patch is from Patrick Georgi but I reimplemented it
> from scratch since I can't reach the other box for a few days. It
> fixes stage0_i586.S assembling on the latest official GNU binutils
> version. Without this patch the compilation fails with:
>
> AS      build/arch/x86/stage0_i586.o
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S: Assembler
> messages:
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> expecting operand after ','; got nothing
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> missing ')'
> /Users/stepan/Devel/coreboot-v3/arch/x86/stage0_i586.S:345: Error:
> expecting operand after ','; got nothing

Sorry, that patch only papers over the bug. If we ever decide to use CAR
at another location, this will break again and we'll have to duplicate
some of the code you touched in the patch. I'd prefer to know why a
division fails, but a subtractoin succeeds.

Regards,
Carl-Daniel