Hi,
(sorry, can't resist to join the thread :)
On Mon, Apr 07, 2008 at 05:10:34PM -0700, Stefan Reinauer wrote:
While in theory I agree with Peter that separating whitespace is a lot easier to read,
Yes.
I don't believe this is really a practical approach.
Yes and no. I personally don't mind one or two whitespace fixes in a patch which actually does functional changes, as long as there are no _massive_ whitespace changes mixed into the patch. Those should definately be separated in an extra patch.
That's not the case in Marc's patch, though.
chaff without being all too confused. If it happens to be viable, yes, please try to make it like that, but NACKing a patch for that reason is unacceptable.
While I'm probably the whitespace fanatic #1 around here I have to agree with this ;) Yes, whitespace fixes are important, and yes they should be in separate patches if there are many of them, but that's not a reason to NACK a patch, IMO...
Uwe.