Re: [LinuxBIOS] [PATCH] flashrom: Support EON EN29F002AT, JEDEC continuation IDs

[Corey Osgood]

>   /* Check if it is a continuation ID, this should be a while
>
> loop. */
>   if (id1 == 0x7F) {
>           largeid1 <<= 8;
>           id1 = *(volatile uint8_t *)(bios + 0x100);
>           largeid1 |= id1;
>   }
>   if (id2 == 0x7F) {
>           largeid2 <<= 8;
>           id2 = *(volatile uint8_t *)(bios + 0x101);
>           largeid2 |= id2;
>   }

are you sure this is right? The IDs are, at most, just 0x7f7f7fXX? Just
doesn't seem quite right, but it might be (yes, I realize it means 4x
more IDs). We also break the ability to use IMT flash chips (which
someone may, eventually...). The other things is, if it should be a
while loop, why isn't it?

You also forgot your email in the copyright header in flashchips.c.

-Corey

Carl-Daniel Hailfinger wrote:
> On 18.12.2007 00:53, Carl-Daniel Hailfinger wrote:
> > Hi Markus,
> >
> > On 24.09.2007 00:38, Carl-Daniel Hailfinger wrote:
> > > On 31.08.2007 21:40, Markus Boas wrote:
> > > > I send a patch to add support for the EON EN29F002NT
> > > > Write, read works.
> > >
> > > Sorry, but the data sheet says you're only doing half of the
> > > identification and this will match all EON chips.
> >
> > Can you test this patch? If identification fails, can you post the
> > output of "flashrom --verbose" ? Thanks!
> >
> > Add continuation ID support to jedec.c
> > Add support for EON EN29F002AT.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Anyone able to review this?
>
> Regards,
> Carl-Daniel