Re: [coreboot] [commit] r6373 - in trunk/src/superio: fintek/f71805f fintek/f71859 fintek/f71863fg fintek/f71872 fintek/f71889 intel/i3100 ite/it8712f ite/it8716f smsc/lpc47b272 smsc/lpc47b397 smsc/lpc47m10x smsc...

[Peter Stuge]

Stefan Reinauer wrote:
> > +++ trunk/src/superio/smsc/lpc47n227/superio.c	Sat Feb 19 15:51:31 2011	(r6373)

..
> > lpc47n227_pnp_set_enable(dev, (dev->enabled) ? 1 : 0);
> > lpc47n227_pnp_set_enable(dev, !!dev->enabled);
>
> How's this different?

This particular file did not have a functional change, but others
did.
> I like the ?: notion more than the :: notion.

I also like !! and I guess this file was changed to make this code
look the same everywhere.

Maybe it could even be moved to a common function.

//Peter