On Tue, Dec 07, 2010 at 11:05:19PM +0100, Stefan Reinauer wrote:
Hi Uwe,
good approach!
- Uwe Hermann uwe@hermann-uwe.de [101206 23:45]:
Move "select CACHE_AS_RAM" lines from boards into CPU socket.
I generally like this idea, but that is not the only thing the patch does. If it did, it were Acked-by: Stefan Reinauer stepan@coreboot.org
All K8/Fam10h boards use CAR, so move the "select CACHE_AS_RAM" into model_fxx/Kconfig and model_10xxx/Kconfig, and remove it from the individual boards and the individual sockets using model_fxx/model_10xxx.
I think CAR should be selected in the socket, not in the model. In case of the AMD K8 CPUs it is not a big difference, but in general, a socket should be the entity to decide whether a given setup can run CAR or not.
Yep, I agree, comitted as r6151 resuing your ack. I moved all those selects to the socket, and changed the model_10xxx to do the same (it already had the select in model_10xxx, not in the sockets).
In addition, this is ugly because the actual code selection for CAR still happens in the socket_*** Makefile.inc, so if there is a good reason for moving from socket to model (except we wouldn't have to add a line to each socket rather than just two models,
Nope, no other reason, I just wanted to save a few lines. I agree consistency across all sockets/CPUs is much more important here, though.
Uwe.