Re: [coreboot] [PATCH] Streamline CPU_ADDR_BITS usage

[Patrick Georgi]

Am 03.10.2010 20:47, schrieb Uwe Hermann:
> movl	$0xff, %edx /* (1 << (CONFIG_CPU_ADDR_BITS - 32)) - 1 for K8 (CONFIG_CPU_ADDR_BITS = 40) */
> jmp_if_k8(wbcache_post_fam10_setup)
> movl	$0xffff, %edx /* (1 << (CONFIG_CPU_ADDR_BITS - 32)) - 1 for FAM10 (CONFIG_CPU_ADDR_BITS = 48) */
>
> -wbcache_post_fam10_setup:
> movl	$CONFIG_CPU_ADDR_BITS_MASK, %edx

This was to allow a single image to run through CAR with both K8 and
Fam10. I suppose that's not necessary anymore, given that the bootblock
doesn't use CAR, and any chip selection can and should happen there.

So I think it's safe to go ahead with that one - just stating since
you're seriously changing behaviour here.

Patrick