On Thu, 2021-11-11 at 15:21 +0100, Nico Huber wrote:
Hi,
On 11.11.21 14:05, Julian Stecklina wrote:
with the following patch, the Qemu coreboot image indeed does not write to ROM anymore.
The question is whether this is behavior that is also considered broken on qemu?
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 19f0fca5abe9..eba8d00bd761 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -15,7 +15,7 @@ config BOARD_SPECIFIC_OPTIONS select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_ASAN_IN_ROMSTAGE select NO_SMM - select BOOT_DEVICE_NOT_SPI_FLASH + select BOOT_DEVICE_SPI_FLASH
this wouldn't be correct as QEMU doesn't emulate SPI, IIRC. However, selecting BOOT_DEVICE_MEMORY_MAPPED directly would reflect reality. Not sure if it's that easy, though ;)
Just selecting BOOT_DEVICE_MEMORY_MAPPED in the qemu Kconfigs works just fine. I'll try to send a patch to Gerrit, if I can defeat the tooling for that. :)
Julian