Re: [coreboot] [BUILDROM] coreboot rename

[Uwe Hermann]

> Index: buildrom-devel/Config.in
>
> --- buildrom-devel.orig/Config.in	2008-01-17 16:33:09.000000000 -0700
> +++ buildrom-devel/Config.in	2008-01-17 16:34:10.000000000 -0700
> @@ -45,24 +45,24 @@
>  endmenu
>
> -menu "LinuxBIOS configuration"
> +menu "coreboot configuration"
>
> choice
> prompt "LinuxBIOS Version"
> default LINUXBIOS_V2
> prompt "coreboot Version"

"Version" -> "version", I'd say.
> +# corebootv2 configuration

"coreboot v2" to be consistent.
> +# coreboot v3 configuration
> +CBV3_CONFIG=qemu-i386-defconfig
> +CBV3_TAG=HEAD
> +CBV3_ROM_NAME=linuxbios.rom
>
> +COREBOOT_VENDOR=emulation
> +COREBOOT_BOARD=qemu-i386
> +CBV2_TDIR=qemu-i386

Shouldn't this be CBV3_TDIR here?
> -include $(PACKAGE_DIR)/linuxbios/linuxbios.inc
> +include $(PACKAGE_DIR)/coreboot-v2/coreboot.inc

Is this specific to v2? If yes: coreboot-v2.inc.
> -include $(PACKAGE_DIR)/linuxbios/linuxbios.inc
> +include $(PACKAGE_DIR)/coreboot-v2/coreboot.inc
>
> # This matches the base name of the ROM on
> -# http://www.linuxbios.org/data/optionroms/
> +# http://www.coreboot.org/data/optionroms/

I'd drop the "www." here.

Hm, I just noticed the webserver adds the "www" automatically, even if
you don't specify it. I think this has changed recently,
http://linxubios.org used to work (and no "www" was added).
> Index: buildrom-devel/packages/linuxbios/optionroms.inc
>
> --- buildrom-devel.orig/packages/linuxbios/optionroms.inc	2008-01-17 16:33:09.000000000 -0700
> +++ buildrom-devel/packages/linuxbios/optionroms.inc	2008-01-17 16:35:27.000000000 -0700
> @@ -1,7 +1,7 @@
> -# Rules to download option roms from the LinuxBIOS option rom
> +# Rules to download option roms from the coreboot option rom

option ROM(s)
> Index: buildrom-devel/packages/linuxbiosv3/linuxbiosv3.mk
>
> --- buildrom-devel.orig/packages/linuxbiosv3/linuxbiosv3.mk	2008-01-17 16:33:08.000000000 -0700
> +++ buildrom-devel/packages/linuxbiosv3/linuxbiosv3.mk	2008-01-17 16:36:41.000000000 -0700

[...]
> +$(SOURCE_DIR)/$(CBV3_TARBALL):
> @ mkdir -p $(SOURCE_DIR)/coreboot-v3
> @ $(BIN_DIR)/fetchsvn.sh $(CBV3_URL) \
> $(SOURCE_DIR)/coreboot-v3 $(CBV3_TAG) \
> $@ > $(CBV3_FETCH_LOG) 2>&1
>
> +$(CBV3_STAMP_DIR)/.unpacked: $(SOURCE_DIR)/$(CBV3_TARBALL)
> @echo "Unpacking coreboot-v3..."

This should be "coreboot v3" to be consistent with the other changes.

IMO these are our (current) rules:
 - human-readable name (README, comments, wiki): coreboot v3
 - machine-readable (file/directory/variable names): coreboot-v3
> @ echo "Patching coreboot-v3..."

[...]
> @ echo "Configuring coreboot-v3..."

[...]
> @ echo "Building coreboot-v3..."

[...]
> @ echo "Cleaning coreboot-v3..."

Ditto, "coreboot v3".

Otherwise the patch looks good, so:

Acked-by: Uwe Hermann

I didn't actually _test_ it, though.

Uwe.