On 20.10.2008 19:28, ron minnich wrote:
attached.
corrections and improvements welcome. Builds fine on serengeti. Not testing until we work around the vga issue.
These changes add support for utility functions to dump routing. They also add a mainboard.c for serengeti that will call them.
Since it is in the mainboard directory, the name "mainboard.c" does not convey any additional information. However, the name stage2.c would be rather helpful. Your choice, though.
Interesting note: adding a set of mainboard ops and mainboard.c for mainboards is trivial: create file, add to makefile, add property to mainboard dts, done. A good sign that we got something right.
Indeed.
Index: northbridge/amd/k8/Makefile Add util.c to stage2 files.
Index: northbridge/amd/k8/util.c Utility to print routing registers.
Index: mainboard/amd/serengeti/mainboard.c new mainboard.c -- currently, only use is that the phase6 init calls the code to show all routing registers as a debug function, but it shows how to use a stage2 mainboard file.
Index: mainboard/amd/serengeti/Makefile add mainboard.c to makefile.
Index: mainboard/amd/serengeti/dts add device_operations="serengeti"; property, so we link in to mainboard device ops.
Index: include/arch/x86/amd/k8/k8.h k8.h: add defines for start and end of routing registers.
If you add your signoff, this is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel