Re: [coreboot] NEW PATCH -- please ignore previous PIRQ patch

[Carl-Daniel Hailfinger]

On 09.02.2008 16:32, ron minnich wrote:
> Here is my suggested copyright notice for the
> arch/x86/pirq_routing.c
> file
>
> /*
> This file is part of the coreboot project.
> Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
> Copyright (C) 2000 Ron Minnich
> Copyright (C) 2001 Eric Biederman
> Copyright (C) 2002 Andrew Ip
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */

I think you changed enough code to add year 2008 to your copyright line.
> For the include file, I am suggesting this:
>
> /*
> This file is part of the coreboot project.
> Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */

No copyright from you?
> Let me know if this is ok.

You decide on the questions above, but in any case I'd say: Go ahead!

Regards,
Carl-Daniel