NEW PATCH -- please ignore previous PIRQ patch

[ron minnich]

Interrupts are up and working on the LX on v3! Ethernet, USB, etc. --
it's all working.

We may be close to moving all LX boards to v3. This is a big day.

patch attached.

ron

[Corey Osgood]

On Feb 9, 2008 2:36 AM, ron minnich  wrote:
> Interrupts are up and working on the LX on v3! Ethernet, USB, etc. --
> it's all working.
>
> We may be close to moving all LX boards to v3. This is a big day.
>
> patch attached.
>
> ron

Awesome!

One thing I think you missed:

Index: arch/x86/archtables.c
> ===================================================================
> --- arch/x86/archtables.c    (revision 581)
> +++ arch/x86/archtables.c    (working copy)
> @@ -79,8 +79,13 @@
>      post_code(POST_STAGE2_ARCH_WRITE_TABLES_ENTER);
>  /* This table must be betweeen 0xf0000 & 0x100000 */
>
> -//    rom_table_end = write_pirq_routing_table(rom_table_end);
> -//    rom_table_end = (rom_table_end + 1023) & ~1023;
> /* we need to make a decision: create empty functions
>  * in .h files if the cpp variable is undefined, or #ifdef?
>  */
>
> +#ifdef CONFIG_PIRQ_TABLES
> rom_table_end = write_pirq_routing_table(rom_table_end);
> rom_table_end = (rom_table_end + 1023) & ~1023;
>
> +#endif

Should be CONFIG_PIRQ_TABLE?

Also, is there copyright info for the pirq routing table files? We should be
preserving that or adding it, it'll never be any easier then right now.

-Corey

[ron minnich]

On Feb 8, 2008 11:44 PM, Corey Osgood  wrote:
> > +#ifdef CONFIG_PIRQ_TABLES
> > rom_table_end = write_pirq_routing_table(rom_table_end);
> > rom_table_end = (rom_table_end + 1023) & ~1023;
> >
> > +#endif
>
> Should be CONFIG_PIRQ_TABLE?

Yes, I fixed that last night in the second patch :-)
> Also, is there copyright info for the pirq routing table files? We should be
> preserving that or adding it, it'll never be any easier then right now.

Well, good question. The most original author, I believe, was Ollie
Lo. It was Ollie who first created the irq table support in 2000.

I am inclined to assign the files to Olllie. Comments?

ron

[ron minnich]

Here is my suggested copyright notice for the
arch/x86/pirq_routing.c
file

/*
 * This file is part of the coreboot project.
 *
 * Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
 * Copyright (C) 2000 Ron Minnich
 * Copyright (C) 2001 Eric Biederman
 * Copyright (C) 2002 Andrew Ip
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 */

For the include file, I am suggesting this:

/*
 * This file is part of the coreboot project.
 *
 * Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 */

Let me know if this is ok.

ron

[Carl-Daniel Hailfinger]

On 09.02.2008 16:32, ron minnich wrote:
> Here is my suggested copyright notice for the
> arch/x86/pirq_routing.c
> file
>
> /*
> This file is part of the coreboot project.
> Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
> Copyright (C) 2000 Ron Minnich
> Copyright (C) 2001 Eric Biederman
> Copyright (C) 2002 Andrew Ip
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */

I think you changed enough code to add year 2008 to your copyright line.
> For the include file, I am suggesting this:
>
> /*
> This file is part of the coreboot project.
> Copyright (C) 2000 Ollie Lo, Silicon Integrated Systems
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> This program is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> GNU General Public License for more details.
> You should have received a copy of the GNU General Public License
> along with this program; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */

No copyright from you?
> Let me know if this is ok.

You decide on the questions above, but in any case I'd say: Go ahead!

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

On 09.02.2008 08:36, ron minnich wrote:
> Interrupts are up and working on the LX on v3! Ethernet, USB, etc. --
> it's all working.
>
> We may be close to moving all LX boards to v3. This is a big day.

Yes! A very big day indeed.
> patch attached.
>
> ron

Can we have the change below as an extra commit, maybe with a short
version of the commit message in the code as comment near the #if 0? See
below.
> Index: util/x86emu/vm86.c
> Comment out 'debug trap' code that scribbles vectors at 0x4000. 
> I don't know why this is here, but I'd like to leave it #if'ed out --
> somebody, at some point, thought we needed it.
> Index: util/x86emu/vm86.c
>
> --- util/x86emu/vm86.c	(revision 581)
> +++ util/x86emu/vm86.c	(working copy)
> @@ -595,11 +595,13 @@
>    intbyte = codeptr + 3;
>    *intbyte = 0x42; /* int42 is the relocated int10 */
>
> +#if 0

+#if 0 /* This scribbles vectors at 0x4000, no idea why the code is here. */
> /* debug handler - useful to set a programmable delay between instructions if the
>       TF bit is set upon call to real mode */
>    idts[1].cs = 0;
>    idts[1].offset = 16384;
>    memcpy((void *)16384, &debughandle, &end_debughandle - &debughandle);
> +#endif
>
> }

Regards,
Carl-Daniel

[ron minnich]

Carl-Daniel, I agree with your comments, will add them, but I need an
ack from *somebody* :-)

ron

[Stefan Reinauer]

* ron minnich  [080209 17:21]:
> Carl-Daniel, I agree with your comments, will add them, but I need an
> ack from *somebody* :-)

Acked-by: Stefan Reinauer

[ron minnich]

Committed revision 582.

OK, folks, this is great. We now have our first working hardware
target for v3, we can start to move other LX boards over, and the code
is really pretty nice.

I am finding it nice to work with. I think we did a good job with this
one. And LAR is making life much, much better.

I am going to add the 'empty lar file' today and turn down the debug
prints and get some timing.

ron

[Carl-Daniel Hailfinger]

On 09.02.2008 17:21, ron minnich wrote:
> Carl-Daniel, I agree with your comments, will add them, but I need an
> ack from *somebody* :-)

Sorry, I somehow forgot to include the Ack in my last mail. :-/

The-Patch-is-Great-And-Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel