On 22.02.2007 18:39, Segher Boessenkool wrote:
So yes, it is possible to post
- A patch with only a Sign-off-by: You modified the code, but don't want it to be committed, yet.
You better state that "it's not ready yet" explicitly too in such a case, to avoid confusion.
Very much agreed. A "don't commit" or "RFC" message is much more explicit than a missing ack.
- A patch with a Signed-off-by and an Acked-by: You modified the patch and you think it can be commited.
That's the normal case. I think ack'ing your own patches is pretty meaningless (you cannot really review your own patches) but maybe that's just me.
Yes. If you don't want to ack a patch, simply post it as RFC. As Segher said: You can't really review your own patches.
- An email with just an Acked-by: You didn't touch the patch at all, but you think it can be
committed.
If your ACK is the last needed one, you can just go ahead and commit the patch and send an email stating you did that. The eventual committer has to type in the acked-by lines anyway.
There's one exception: If you don't have commit rights (yet), but you want to ack a patch.
So except for the acking I agree with Uwe.
Regards, Carl-Daniel