Re: [coreboot] [PATCH] s289x ACPI fix

[ron minnich]

On Fri, Oct 16, 2009 at 7:41 AM, Myles Watson  wrote:
> The problem with this style is that it doesn't support conditional
> compilation.  In this case it doesn't matter, but if you wanted to put in:
>
> if(CONFIG_HAVE_MP_TABLE) {
>      use_some_MP_defines();
> }
>
> It would break, wouldn't it?  Since CONFIG_ variables are used to control
> what gets included in the image, I think we should stick with #if.

Why would that break?

ron